-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1092 Update Python/Django versions in tests #1093
Fix #1092 Update Python/Django versions in tests #1093
Conversation
Is there anything left to do? How can we help to get this merged? |
There are a couple things I think we should update before merging.
|
2356203
to
8282339
Compare
Thanks for the feedback, I updated this PR.
I updated the Django versions in install_requires
I updated to version 1.13 I also rebased the branch to let you merge it. |
Sorry, one more thing. Can you please revert the change to |
cec4893
to
ca70489
Compare
I reverted the changes on the version, I rebased to the branch master to resolve a merge conflict and I also added the support to Django 4.1 which was published yesterday. |
@pauloxnet thanks for the persistence. There is now a test failure. |
@jschneier Actually I had forgotten how old this PR is. I realized that in the meantime Django 2.2 is no longer supported, so I updated this PR. Locally the tests pass, I hope they pass even remotely. Unfortunately, as first-time Contributor for this project they will not automatically start, so I will have to wait for your approval to be sure. |
Merged, thanks for the patience. |
Thanks to you |
No description provided.