Fix bug in SFTPStorage._save(). #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eally being passed bytes.
Current coverage is 31.07%@@ master #159 diff @@
==========================================
Files 17 17
Lines 1298 1297 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 403 403
+ Misses 895 894 -1
Partials 0 0
|
|
Hey, thanks for this. This was I believe fixed in #177 via a slightly different tweak. Let me know if you're still seeing issues and sorry for the late response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFTPStorage._save() is only ever called on closing a SFTPStorageFile. SFTPStorageFile passes this method bytes, but SFTPStorage._save() was treating the parameter as a file.