-
-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added project support to GCS through LibCloud #269
Conversation
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
- Coverage 59.32% 59.25% -0.07%
==========================================
Files 17 17
Lines 1694 1696 +2
==========================================
Hits 1005 1005
- Misses 689 691 +2
Continue to review full report at Codecov.
|
The |
@jschneier thanks for the merge. libcloud docs mentioned above refer to this parameter as required, but you probably know better. Just looking at my commit it might be better to use the |
Yeah I agree. What we currently have can only lead to madness. |
Please see the docs here for reference to this paremter.
https://libcloud.readthedocs.io/en/latest/compute/drivers/gce.html
Perhaps the docs should be updated to reflect this.