Dropbox: large file support and a regression fix #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxmalysh
commented
Aug 10, 2017
storages/backends/dropbox.py
Outdated
| @@ -21,6 +21,7 @@ | |||
| from django.utils.deconstruct import deconstructible | |||
| from dropbox import Dropbox | |||
| from dropbox.exceptions import ApiError | |||
| from dropbox.files import UploadSessionCursor, CommitInfo | |||
There was a problem hiding this comment.
The only failing build is lint. Change import order to make it happy:
from dropbox.files import CommitInfo, UploadSessionCursor
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 75.82% 76.05% +0.23%
==========================================
Files 11 11
Lines 1551 1566 +15
==========================================
+ Hits 1176 1191 +15
Misses 375 375
Continue to review full report at Codecov.
|
jschneier
pushed a commit
that referenced
this pull request
Aug 14, 2017
jschneier
pushed a commit
that referenced
this pull request
Aug 14, 2017
nitely
pushed a commit
to satellogic/django-storages
that referenced
this pull request
Jul 30, 2018
* Fix .save method of the Dropbox backend (jschneier#378) * Dropbox large file support (jschneier#301) * Make linter happy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
DropBoxStorage._saveintroduced with e46f306 (see Dropbox storage throws an exception when saving a file #378);I've tested uploading a 1.5 GB file and it works fine.