This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
disallowTrailingWhitespace: use CST for fix method #2180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems there is a jshint error? |
|
Friendly ping |
|
It seems we still have couple failures? |
qfox
force-pushed
the
disallow-trailing-whitespace-fix
branch
from
26d2034
to
265a7b2
Compare
| @@ -46,7 +46,9 @@ var AssertHelpers = { | |||
| it('fix', function() { | |||
| var result = checker.fixString(options.input); | |||
| expect(result.errors).to.have.no.errors(); | |||
| expect(result.output).to.equal(options.output); | |||
| if (result.output !== options.output) { | |||
There was a problem hiding this comment.
Dono why I've added it. Need to drop
qfox
force-pushed
the
disallow-trailing-whitespace-fix
branch
2 times, most recently
from
3e28111
to
8f63819
Compare
qfox
force-pushed
the
disallow-trailing-whitespace-fix
branch
from
8f63819
to
3a16cf0
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @markelog @hzoo