Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Cast StringChecker maxErrors property to Number the first time #688

Merged
merged 1 commit into from
Oct 15, 2014

Conversation

ffesseler
Copy link
Contributor

In max-errors.js, Object.defineProperties cast the config maxErrors property to Number
but not the StringChecker maxErrors property.

This leads to a bug if multiple jscs checks are executed using the same config object
(config.maxerrors will equal 'undefined' the first time, and 'NaN' the second time)

In max-errors.js, Object.defineProperties cast the config maxErrors property to Number
but not the StringChecker maxErrors property.

This leads to a bug if multiple jscs checks are executed using the same config object
(config.maxerrors will equal 'undefined' the first time, and 'NaN' the second time)
@gustavohenke
Copy link
Member

Related: #687

@mikesherov
Copy link
Contributor

@gustavohenke I'll add your unit with @ffesseler's fix. Thanks to both of you!

@mikesherov mikesherov merged commit 776188d into jscs-dev:master Oct 15, 2014
mikesherov pushed a commit that referenced this pull request Oct 15, 2014
@mikesherov
Copy link
Contributor

@ffesseler thanks again!

@gustavohenke
Copy link
Member

@mikesherov Any prevision about a new patch release?

@mikesherov
Copy link
Contributor

Wil release when I get home.

On Thursday, October 16, 2014, Gustavo Henke [email protected]
wrote:

@mikesherov https://github.com/mikesherov Any prevision about a new
patch release?

Reply to this email directly or view it on GitHub
#688 (comment).

Mike Sherov

@mikesherov
Copy link
Contributor

1.7.2 released! https://github.com/jscs-dev/node-jscs/releases/tag/v1.7.2

On Thu, Oct 16, 2014 at 6:30 PM, Mike Sherov [email protected] wrote:

Wil release when I get home.

On Thursday, October 16, 2014, Gustavo Henke [email protected]
wrote:

@mikesherov https://github.com/mikesherov Any prevision about a new
patch release?

Reply to this email directly or view it on GitHub
#688 (comment).

Mike Sherov

Mike Sherov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants