Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculating wrong version number #762

Closed
dgonzalezr opened this issue Dec 22, 2023 · 2 comments
Closed

Calculating wrong version number #762

dgonzalezr opened this issue Dec 22, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@dgonzalezr
Copy link

dgonzalezr commented Dec 22, 2023

Hi,

I wanted to trigger a new release on our Nx monorepo yesterday, but whenever I run:

npx nx run workspace:version

is not picking or calculating the right version, is not taking into account the last version (current v0.10.0) and is calculating for the release v0.9.0 😒 and no change is seen.

Our Nx monorepo release in sync mode, we have been using this plugin in all our releases without issue. The git tags are set correctly and can also be listed in the CLI.

We are kinda block now and we have a bunch of new features that we would like to release as soon as possible. Any help is really appreciated 🙌🏼.

@edbzn edbzn added the bug Something isn't working label Dec 22, 2023
@edbzn
Copy link
Member

edbzn commented Dec 22, 2023

Hey @dgonzalezr, I found out that the issue is due to the custom preset usage. I'm still investigating concretely why but to unlock your release without waiting for a fix you could use the base preset, instead of:

"preset": {
  "name": "conventionalcommits",
  "types": [
    { "type": "feat", "section": "Features ⚡️" },
    { "type": "fix", "section": "Bug Fixes 🐞" },
    { "type": "test", "section": "Test 🧪" },
    { "type": "docs", "section": "Documentation 📚" },
    { "type": "style", "section": "Style 🎨" },
    { "type": "chore", "section": "Chore ⚙️" },
    { "type": "perf", "section": "Performance ⌛️" },
    { "type": "refactor", "hidden": true },
    { "type": "release", "hidden": true }
  ]
}

use "preset": "conventionalcommits, it will work again.

edbzn added a commit that referenced this issue Dec 22, 2023
@edbzn
Copy link
Member

edbzn commented Dec 22, 2023

It's fixed in https://github.com/jscutlery/semver/releases/tag/semver-4.2.0, thank you!

@edbzn edbzn closed this as completed Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants