Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all the Web IDL - Part Two #2081

Merged
merged 1 commit into from
Jan 16, 2018
Merged

Conversation

Zirro
Copy link
Member

@Zirro Zirro commented Dec 12, 2017

Updates for the remaining Web IDL after #2053 handles the nodes/ directory. An exception is Attr.webidl, which I've left unchanged as it depends on the work from #1822.

@Zirro
Copy link
Member Author

Zirro commented Dec 13, 2017

Mainly changes to formatting in this one, but here are other changes of potential consequence:

Event

  • The timeStamp attribute uses DOMHighResTimeStamp instead of DOMTimeStamp

UIEvent

  • No longer has a modifierOS boolean

FileReader

  • error attribute changed from using DOMError to DOMException

History

  • The third argument of pushState() and replaceState() takes a USVString instead of DOMString

@domenic
Copy link
Member

domenic commented Dec 13, 2017

The timeStamp change also came with a spec change that might be worth implementing: whatwg/dom@912d587

@Zirro
Copy link
Member Author

Zirro commented Dec 13, 2017

Okay, I believe I can do that this weekend.

EDIT: The change proved more difficult than initially anticipated, since every event will need to be aware of when window was created. I'll probably revert that line for now.

@Zirro
Copy link
Member Author

Zirro commented Dec 26, 2017

Updated to revert the DOMTimeStamp -> DOMHighResTimeStamp change for now since it appears to require many changes to event constructors and the code leading up to them.

@domenic domenic assigned domenic and unassigned Zirro Jan 16, 2018
@domenic domenic merged commit 1519104 into jsdom:master Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants