Fix addSource
to allow implementation path to point to a file
#212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where:
Would result in
outputDir/Attr.js
requiringpath/to/Attr‑impl.js/Attr.js
instead ofpath/to/Attr‑impl.js
, because the wrapper generation code currently assumes that theimpl
path argument is always a directory.This will also make it possible to implement jsdom/jsdom#2835 without renaming
Window.js
(jsdom/jsdom#2837) by utilising the above mentionimpl
path name fix.