Add tests and tweak None filter interest level
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added tests for max level filtering and interest caching with multiple subscribers. * Changed the interest level for a `None` filter from `sometimes` to `always` so other filters can be cached more effectively.
| // non-dynamic filter fn, which means the result can be cached per callsite. | ||
| // The filter fn should only need to be called once, and the `Option` filter | ||
| // should not interfere in the caching of that result. | ||
| assert_eq!(times_filtered.load(Ordering::Relaxed), 1); |
There was a problem hiding this comment.
With sometimes, the filter fn is evaluated three times:
- For the initial check to see if the callsite is enabled (effectively returns
Interest::always) - For the first debug event
- For the second debug event
With always, only #1 occurs. Both filters are always interested, so there's no need to reevaluate the filter fn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nonefilter fromsometimestoalwaysso other filters can be cached more effectively.