Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try coverage upload from fork #1454

Closed
wants to merge 3 commits into from
Closed

Try coverage upload from fork #1454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc274d1
Bump codecov/codecov-action from 3 to 4
dependabot[bot] Feb 5, 2024
4790001
Add codecov token
bkoelman Feb 6, 2024
0458c37
Add comment to trigger build
bkoelman Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,9 @@ jobs:
dotnet test --no-build --configuration Release --collect:"XPlat Code Coverage" --logger "GitHubActions;summary.includeSkippedTests=true"
- name: Upload coverage to codecov.io
if: matrix.os == 'ubuntu-latest'
uses: codecov/codecov-action@v3
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
uses: codecov/codecov-action@v4
with:
fail_ci_if_error: true
verbose: true
Expand Down
1 change: 1 addition & 0 deletions src/JsonApiDotNetCore/CollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ namespace JsonApiDotNetCore;

internal static class CollectionExtensions
{
// Useless comment to trigger a build.
[Pure]
public static bool IsNullOrEmpty<T>([NotNullWhen(false)] this IEnumerable<T>? source)
{
Expand Down