-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing property key names in output format #1247
Changing property key names in output format #1247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'm glad to hear you're thinking about annotation examples :-)
Like the previous discussion on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you didn't update the schema that validates the output formats. It probably needs a bit of work anyway even before changing the spec.
We have reasons for changing these. They're in the discussion. If we need to change them to something else, then please continue the discussion there. Nothing else has changed there on this topic, so I decided to move forward. |
I think I may leave this one for the end. I'll update the examples as I go, though. |
Going ahead with merging this. If we want to change |
This PR is the start of changes to the output format as discussed here.
It covers changing property names:
keywordLocation
->evaluationPath
absoluteSchemaLocation
->schemaLocation
errors
/annotations
->nested
(In making these edits, I began to see why so many people were asking for examples with annotations. I expected that to be a trivial exercise given the error examples, but I get it now.)