Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase phpstan level to 8 with baseline to swallow existing errors #673

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

Seldaek
Copy link
Contributor

@Seldaek Seldaek commented Jul 28, 2021

Closes #661 - this implements it in a different way, instead of a sub-directory with the phpstan binary we just require phpstan in the CI, so it runs there, but can't easily be run locally (well you have to composer require phpstan/phpstan marc-mabe/php-enum-phpstan --dev && git checkout composer.json then you can call vendor/bin/phpstan in your dev env).

It's a compromise situation until legacy php versions are dropped, which probably would be reasonable to do for 6.0 IMO, but another discussion for another day.

@DannyvdSluijs
Copy link
Collaborator

@Seldaek any change you can do a git rebase master && git push --force-with-lease to trigger the GitHub Actions?
I'm planning to merge this as part of the next version

@Seldaek
Copy link
Contributor Author

Seldaek commented Sep 13, 2024

Ok one sec

@Seldaek Seldaek force-pushed the phpstan branch 2 times, most recently from acb0072 to b7ccf53 Compare September 13, 2024 12:38
@DannyvdSluijs DannyvdSluijs merged commit 5b3bd2b into jsonrainbow:master Sep 13, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants