Increase phpstan level to 8 with baseline to swallow existing errors #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #661 - this implements it in a different way, instead of a sub-directory with the phpstan binary we just require phpstan in the CI, so it runs there, but can't easily be run locally (well you have to
composer require phpstan/phpstan marc-mabe/php-enum-phpstan --dev && git checkout composer.json
then you can callvendor/bin/phpstan
in your dev env).It's a compromise situation until legacy php versions are dropped, which probably would be reasonable to do for 6.0 IMO, but another discussion for another day.