perf: 提供步骤详情与步骤执行结果查询的APIGW接口 TencentBlueKing#2596

处理Review意见
jsonwan · Nov 27, 2023 · 482d788 · 482d788
1 parent 1b11121
commit 482d788
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/...c/main/java/com/tencent/bk/job/execute/api/esb/v3/EsbGetStepInstanceDetailV3Resource.java b/...c/main/java/com/tencent/bk/job/execute/api/esb/v3/EsbGetStepInstanceDetailV3Resource.java
@@ -35,8 +35,8 @@
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 
+import javax.validation.constraints.Min;
 import javax.validation.constraints.NotNull;
-import javax.validation.constraints.Positive;
 
 /**
  * 根据步骤实例 ID 查询步骤执行详情API-V3
@@ -55,11 +55,11 @@ EsbResp<EsbStepV3DTO> getStepInstanceDetail(
         @RequestParam(value = "bk_scope_id") String scopeId,
         @RequestParam(value = "job_instance_id")
         @NotNull(message = "{validation.constraints.InvalidJobInstanceId.message}")
-        @Positive(message = "{validation.constraints.InvalidJobInstanceId.message}")
+        @Min(message = "{validation.constraints.InvalidJobInstanceId.message}", value = 1L)
             Long taskInstanceId,
         @RequestParam(value = "step_instance_id")
         @NotNull(message = "{validation.constraints.InvalidStepInstanceId.message}")
-        @Positive(message = "{validation.constraints.InvalidStepInstanceId.message}")
+        @Min(message = "{validation.constraints.InvalidStepInstanceId.message}", value = 1L)
             Long stepInstanceId);
 
 }
diff --git a/...c/main/java/com/tencent/bk/job/execute/api/esb/v3/EsbGetStepInstanceStatusV3Resource.java b/...c/main/java/com/tencent/bk/job/execute/api/esb/v3/EsbGetStepInstanceStatusV3Resource.java
@@ -35,8 +35,8 @@
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 
+import javax.validation.constraints.Min;
 import javax.validation.constraints.NotNull;
-import javax.validation.constraints.Positive;
 
 /**
  * 根据步骤实例 ID 查询步骤执行状态API-V3
@@ -54,10 +54,10 @@ EsbResp<EsbStepInstanceStatusV3DTO> getStepInstanceStatus(
         @RequestParam(value = "bk_scope_type") String scopeType,
         @RequestParam(value = "bk_scope_id") String scopeId,
         @NotNull(message = "{validation.constraints.InvalidJobInstanceId.message}")
-        @Positive(message = "{validation.constraints.InvalidJobInstanceId.message}")
+        @Min(message = "{validation.constraints.InvalidJobInstanceId.message}", value = 1L)
         @RequestParam(value = "job_instance_id") Long taskInstanceId,
         @NotNull(message = "{validation.constraints.InvalidStepInstanceId.message}")
-        @Positive(message = "{validation.constraints.InvalidStepInstanceId.message}")
+        @Min(message = "{validation.constraints.InvalidStepInstanceId.message}", value = 1L)
         @RequestParam(value = "step_instance_id") Long stepInstanceId,
         @RequestParam(value = "execute_count", required = false) Integer executeCount,
         @RequestParam(value = "batch", required = false) Integer batch,