Skip to content
This repository has been archived by the owner on May 8, 2022. It is now read-only.

making droppablesActive as a config #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikhilkataria-salesforce

This solves the perf issue discussed in #39.

One can now set isDroppablesActive false as part of DragOptions while making the source as follows:
jsPlumbInstance.makeSource(idList, dragOptions: {
isDroppablesActive : false
})

@sporritt
Copy link
Member

Thanks for this. But I'm not sure I want to merge it. In #39 I mentioned a different possible fix which would be preferable from my point of view because it doesn't introduce extra complexity.

If we added this functionality it would of course be off by default. Then to know it has to be switched on a user first has to encounter the issue you encountered, then take it upon themselves to investigate, which ought to mean reading the documentation but in practice I can assure you it means asking me. So I would write some more docs that I'd have to maintain and noone would read, and there'd be more things for people to know, levers to pull, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants