Allow changing the FormatOptions.Default values

Fixes issue #993
jstedfast · Jan 27, 2024 · 4b77a9f · 4b77a9f
1 parent 6e9322c
commit 4b77a9f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 57 deletions.
diff --git a/MimeKit/FormatOptions.cs b/MimeKit/FormatOptions.cs
@@ -106,15 +106,9 @@ public class FormatOptions
 		/// <exception cref="ArgumentOutOfRangeException">
 		/// <paramref name="value"/> is out of range. It must be between 60 and 998.
 		/// </exception>
-		/// <exception cref="System.InvalidOperationException">
-		/// <see cref="Default"/> cannot be changed.
-		/// </exception>
 		public int MaxLineLength {
 			get { return maxLineLength; }
 			set {
-				if (this == Default)
-					throw new InvalidOperationException ("The default formatting options cannot be changed.");
-
 				if (value < MinimumLineLength || value > MaximumLineLength)
 					throw new ArgumentOutOfRangeException (nameof (value));
 
@@ -133,15 +127,9 @@ public int MaxLineLength {
 		/// <exception cref="System.ArgumentOutOfRangeException">
 		/// <paramref name="value"> is not a valid <see cref="NewLineFormat"/>.</paramref>
 		/// </exception>
-		/// <exception cref="System.InvalidOperationException">
-		/// <see cref="Default"/> cannot be changed.
-		/// </exception>
 		public NewLineFormat NewLineFormat {
 			get { return newLineFormat; }
 			set {
-				if (this == Default)
-					throw new InvalidOperationException ("The default formatting options cannot be changed.");
-
 				switch (newLineFormat) {
 				case NewLineFormat.Unix:
 				case NewLineFormat.Dos:
@@ -165,17 +153,9 @@ public NewLineFormat NewLineFormat {
 		/// that writing the message back to a stream will always end with a new-line sequence.</para>
 		/// </remarks>
 		/// <value><c>true</c> in order to ensure that the message will end with a new-line sequence; otherwise, <c>false</c>.</value>
-		/// <exception cref="System.InvalidOperationException">
-		/// <see cref="Default"/> cannot be changed.
-		/// </exception>
 		public bool EnsureNewLine {
 			get { return ensureNewLine; }
-			set {
-				if (this == Default)
-					throw new InvalidOperationException ("The default formatting options cannot be changed.");
-
-				ensureNewLine = value;
-			}
+			set { ensureNewLine = value; }
 		}
 
 		internal IMimeFilter CreateNewLineFilter (bool ensureNewLine = false)
@@ -229,17 +209,9 @@ public HashSet<HeaderId> HiddenHeaders {
 		/// (<a href="https://tools.ietf.org/html/rfc6855">rfc6855</a>).</para>
 		/// </remarks>
 		/// <value><c>true</c> if the new internationalized formatting should be used; otherwise, <c>false</c>.</value>
-		/// <exception cref="System.InvalidOperationException">
-		/// <see cref="Default"/> cannot be changed.
-		/// </exception>
 		public bool International {
 			get { return international; }
-			set {
-				if (this == Default)
-					throw new InvalidOperationException ("The default formatting options cannot be changed.");
-
-				international = value;
-			}
+			set { international = value; }
 		}
 
 		/// <summary>
@@ -260,12 +232,7 @@ public bool International {
 		/// <value><c>true</c> if the formatter should be allowed to use us-ascii and/or iso-8859-1 when encoding headers; otherwise, <c>false</c>.</value>
 		public bool AllowMixedHeaderCharsets {
 			get { return allowMixedHeaderCharsets; }
-			set {
-				if (this == Default)
-					throw new InvalidOperationException ("The default formatting options cannot be changed.");
-
-				allowMixedHeaderCharsets = value;
-			}
+			set { allowMixedHeaderCharsets = value; }
 		}
 
 		/// <summary>
@@ -288,9 +255,6 @@ public bool AllowMixedHeaderCharsets {
 		public ParameterEncodingMethod ParameterEncodingMethod {
 			get { return parameterEncodingMethod; }
 			set {
-				if (this == Default)
-					throw new InvalidOperationException ("The default formatting options cannot be changed.");
-
 				switch (value) {
 				case ParameterEncodingMethod.Rfc2047:
 				case ParameterEncodingMethod.Rfc2231:
@@ -315,12 +279,7 @@ public ParameterEncodingMethod ParameterEncodingMethod {
 		/// <value><c>true</c> if Content-Type and Content-Disposition parameters should always be quoted; otherwise, <c>false</c>.</value>
 		public bool AlwaysQuoteParameterValues {
 			get { return alwaysQuoteParameterValues; }
-			set {
-				if (this == Default)
-					throw new InvalidOperationException ("The default formatting options cannot be changed.");
-
-				alwaysQuoteParameterValues = value;
-			}
+			set { alwaysQuoteParameterValues = value; }
 		}
 
 		static FormatOptions ()

diff --git a/UnitTests/FormatOptionsTests.cs b/UnitTests/FormatOptionsTests.cs
@@ -41,17 +41,5 @@ public void TestArgumentExceptions ()
 
 			Assert.DoesNotThrow (() => format.MaxLineLength = 72);
 		}
-
-		[Test]
-		public void TestInvalidOperationExceptions ()
-		{
-			Assert.Throws<InvalidOperationException> (() => FormatOptions.Default.MaxLineLength = 998, "MaxLineLength");
-			Assert.Throws<InvalidOperationException> (() => FormatOptions.Default.EnsureNewLine = true, "EnsureNewLine");
-			Assert.Throws<InvalidOperationException> (() => FormatOptions.Default.International = true, "International");
-			Assert.Throws<InvalidOperationException> (() => FormatOptions.Default.NewLineFormat = NewLineFormat.Dos, "NewLineFormat");
-			Assert.Throws<InvalidOperationException> (() => FormatOptions.Default.AllowMixedHeaderCharsets = true, "AllowMixedHeaderCharsets");
-			Assert.Throws<InvalidOperationException> (() => FormatOptions.Default.ParameterEncodingMethod = ParameterEncodingMethod.Rfc2047, "ParameterEncodingMethod");
-			Assert.Throws<InvalidOperationException> (() => FormatOptions.Default.AlwaysQuoteParameterValues = true, "AlwaysQuoteParameterValues");
-		}
 	}
 }