Just followed the MimeEntity code approach to avoid non formatted con… #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tent id often generated by different clients
|
Can you give me an example of what the value looks like for you? I don't think MailboxAddress.TryParse is the right way to go (altho you are probably headed in the right direction). |
|
I got same mail from customer from 2 devices where for normal MIME mail
success via MimeKit but couldn't success for tnef format. (here both cases
Content-ID: <[Untitled].pdf>)
In this case, you implementation is absolutely fine and it fully matches
with the spec. But the problem is different application clients doesn't
provide Content-ID according to spec. Even from the forum I have read that
gmail also some time doesn't provides.
So if you check your code of MimeEntity.cs line 1082, you will find same
implementation like I added in TnefPart.cs. I have just followed your
implementation on tnef format.
…On Fri, Mar 15, 2019 at 2:52 PM Jeffrey Stedfast ***@***.***> wrote:
Can you give me an example of what the value looks like for you?
I don't think MailboxAddress.TryParse is the right way to go (altho you
are probably headed in the right direction).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#471 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPPgtCixSRen6uc4k2jP8F0Y73Uziy9ks5vW6WigaJpZM4b2Y4p>
.
--
Humayun Ahmed
|
|
Ah, okay, I see what you meant now when you said you copied the MimeEntity logic. My brain just didn't make that logical connection before. |
Minor code cleanup / stylistic fixes.
jstedfast
approved these changes
Mar 15, 2019
|
Thanks a lot :)
…On Fri, Mar 15, 2019 at 3:09 PM Jeffrey Stedfast ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#471 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPPghq7rQ3JJUIjEL1GflpUydbDXsrsks5vW6mpgaJpZM4b2Y4p>
.
--
Humayun Ahmed
|
|
BTW, I now have both MimeKit and MailKit setup with myget.org as a NuGet feed for rolling CI builds. You can find the links on the main MimeKit/MailKit github home pages. |
|
Thank you
…On Fri, Mar 15, 2019 at 3:12 PM Jeffrey Stedfast ***@***.***> wrote:
BTW, I now have both MimeKit and MailKit setup with myget.org as a NuGet
feed for rolling CI builds.
You can find the links on the main MimeKit/MailKit github home pages.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#471 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABPPgrOIA0vWsnF508648SI5997kTeE0ks5vW6oxgaJpZM4b2Y4p>
.
--
Humayun Ahmed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tent id often generated by different clients