Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade axe-core for more features (it's pinned right now) #989

Closed
norgeous opened this issue Jun 4, 2024 · 7 comments
Closed

Upgrade axe-core for more features (it's pinned right now) #989

norgeous opened this issue Jun 4, 2024 · 7 comments

Comments

@norgeous
Copy link
Contributor

norgeous commented Jun 4, 2024

Would it be possible to unpin axe-core dep?

https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/package.json#L82

Currently it is pinned to =4.7.0 in eslint-plugin-jsx-a11y

The latest available is 4.9.1 (at time of writing)

https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md

Personally, I am interested in any version above 4.7.1, as that adds support for CSS4 colors such as lch, oklch, lab, oklab

Thanks!

@norgeous
Copy link
Contributor Author

norgeous commented Jun 4, 2024

related: #792

@ljharb
Copy link
Member

ljharb commented Jun 4, 2024

The reason we're pinned to v4.7.0 is due to failing tests; see 8d8f016 and dequelabs/axe-core#4127

If indeed v4.9.0 fixed that, then a PR to unpin it would be great!

@norgeous
Copy link
Contributor Author

norgeous commented Jun 5, 2024

It seems the tests (npm run test:ci) are compatible with ^4.9.1 🎉

Screenshot 2024-06-05 143640

Screenshot 2024-06-05 143035

But im using node v22.2.0... does that all seem correct?

Or do i need to run the tests with some other specific node version?

@ljharb
Copy link
Member

ljharb commented Jun 5, 2024

You'd need to run the tests with node 4 or 6, yes.

@norgeous
Copy link
Contributor Author

norgeous commented Jun 5, 2024

After a bit of dicking about with versions of node, npm and eslint

npm i -g npm@4; npm i -g npm@6; npm -i eslint@3

I did some local testing:

node version npm version eslint version axe-core version test result note
v6.17.1 v6.14.16 3.19.0 =4.7.0 ✅66 same as main branch (just checking)
v6.17.1 v6.14.16 3.19.0 =4.7.1 ❌8 ✅58 TypeError: Object.values is not a function
v6.17.1 v6.14.16 3.19.0 ^4.9.1 ✅66 all passing!

i guess, i will open that PR

norgeous added a commit to norgeous/eslint-plugin-jsx-a11y that referenced this issue Jun 5, 2024
previously =4.7.0, now ^4.9.1

see jsx-eslint#989
and jsx-eslint#792
@ljharb
Copy link
Member

ljharb commented Jun 5, 2024

node versions are what matters, not npm versions, but let's look at the tests on the PR :-)

@ljharb
Copy link
Member

ljharb commented Jun 10, 2024

Fixed in #990.

@ljharb ljharb closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants