-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade axe-core
for more features (it's pinned right now)
#989
Comments
related: #792 |
The reason we're pinned to v4.7.0 is due to failing tests; see 8d8f016 and dequelabs/axe-core#4127 If indeed v4.9.0 fixed that, then a PR to unpin it would be great! |
You'd need to run the tests with node 4 or 6, yes. |
After a bit of dicking about with versions of node, npm and eslint
I did some local testing:
i guess, i will open that PR |
previously =4.7.0, now ^4.9.1 see jsx-eslint#989 and jsx-eslint#792
node versions are what matters, not npm versions, but let's look at the tests on the PR :-) |
Fixed in #990. |
Would it be possible to unpin
axe-core
dep?https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/main/package.json#L82
Currently it is pinned to
=4.7.0
ineslint-plugin-jsx-a11y
The latest available is
4.9.1
(at time of writing)https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md
Personally, I am interested in any version above
4.7.1
, as that adds support for CSS4 colors such as lch, oklch, lab, oklabThanks!
The text was updated successfully, but these errors were encountered: