add window to isInteractive #940
Conversation
sangikhan29
changed the title
This reverts commit 597f1de.
This reverts commit d10e775.
|
blocked by #941 ! |
I saw this as well over the weekend. Trying to get this train back on the rails. |
ljharb
force-pushed
the
sangik-interactive-dialog
branch
from
91dd1cf
to
453785f
Compare
ljharb
changed the title
|
Rebased, and moved "draft" from the title to the PR status. @sangikhan29, please mark as ready for review whenever it is. |
| { code: '<dialog>Save</dialog>' }, | ||
| // Interactive Roles | ||
| { code: '<div role="alertdialog">Save</div>' }, | ||
| { code: '<div role="button">Save</div>' }, | ||
| { code: '<div role="checkbox">Save</div>' }, | ||
| { code: '<div role="columnheader">Save</div>' }, | ||
| { code: '<div role="combobox">Save</div>' }, | ||
| { code: '<div role="dialog">Save</div>' }, |
There was a problem hiding this comment.
I think it's fair to expect dialog to have a label according to this.
Codecov Report
@@ Coverage Diff @@
## main #940 +/- ##
==========================================
- Coverage 99.29% 99.02% -0.27%
==========================================
Files 104 105 +1
Lines 1555 1640 +85
Branches 523 576 +53
==========================================
+ Hits 1544 1624 +80
- Misses 11 16 +5
|
| && rolesMap.get(name).superClass.some((klasses) => includes(klasses, 'widget')) | ||
| && rolesMap.get(name).superClass.some((klasses) => includes(klasses, 'widget') || includes(klasses, 'window')) |
There was a problem hiding this comment.
I find this change to be the easiest way to implement this suggestion. But I realized that this change will also impact interactive-supports-focus, where the linter will throw an error if a dialog isn't focusable. But according to mdn, dialog is not required to be focusable although it should have a child that's focusable.
My case for requesting dialog to be interactive (reference) was for more so that it should be allowed (rather than required) to be interactive. I'd feel more comfortable just treating dialog somewhat similarly to presentation on case-by-base basis rather than have it follow all the expectations attached to an interactive role.
@jessebeach would do you have any concerns with just adding custom checks for dialog(+alertdialog) in no-static-element-interactions and no-noninteractive-element-interactions rather than setting window to be interactive? cc: @ckundo
|
I'm seeing the tasks and commentary come through email. Work-work is a bit bananas lately. As soon as we get through the end-of-the-year push and slide into the holidays, I'll have time to focus on this repo. |
|
Sounds good :-) no pressure. |
|
hi friends, bumping this in case there's still an appetite for it! |
Addresses #932