Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some JSX-specific rules to include "jsx-" prefix #668

Closed
lencioni opened this issue Jul 7, 2016 · 0 comments
Closed

Rename some JSX-specific rules to include "jsx-" prefix #668

lencioni opened this issue Jul 7, 2016 · 0 comments

Comments

@lencioni
Copy link
Collaborator

lencioni commented Jul 7, 2016

It seems that this naming convention hasn't been applied consistently. I think that it might be helpful to rename a few rules that are JSX-specific and not really React-specific:

  • no-comment-textnodes -> jsx-no-comment-textnodes
  • require-extension -> jsx-require-extension
  • wrap-multilines -> jsx-wrap-multilines

and maybe

  • self-closing-comp -> jsx-self-closing-comp
@yannickcr yannickcr mentioned this issue Jul 17, 2016
Closed
9 tasks
lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Jul 18, 2016
@lencioni
Rename no-comment-textnodes to jsx-no-comment-textnodes
2ed6995 
This rule is JSX-specific, not React-specific. Changing its name makes
this clearer. I've kept the old one around as deprecated. We can remove
it at the next major version bump.

Addresses jsx-eslint#668 and jsx-eslint#686.
lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Jul 18, 2016
@lencioni
Rename require-extension to jsx-require-extension
42d81ae 
This rule is JSX-specific, not React-specific. Changing its name makes
this clearer. I've kept the old one around as deprecated. We can remove
it at the next major version bump.

Addresses jsx-eslint#668 and jsx-eslint#686.
lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Jul 18, 2016
@lencioni
Rename wrap-multilines to jsx-wrap-multilines
8d86f11 
This rule is JSX-specific, not React-specific. Changing its name makes
this clearer. I've kept the old one around as deprecated. We can remove
it at the next major version bump.

Addresses jsx-eslint#686. Fixes jsx-eslint#668.
@lencioni lencioni mentioned this issue Jul 18, 2016
Merged
lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Jul 20, 2016
@lencioni
Rename no-comment-textnodes to jsx-no-comment-textnodes
9ad4c69 
This rule is JSX-specific, not React-specific. Changing its name makes
this clearer. I've kept the old one around as deprecated. We can remove
it at the next major version bump.

Addresses jsx-eslint#668 and jsx-eslint#686.
lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Jul 20, 2016
@lencioni
Rename require-extension to jsx-require-extension
6260e49 
This rule is JSX-specific, not React-specific. Changing its name makes
this clearer. I've kept the old one around as deprecated. We can remove
it at the next major version bump.

Addresses jsx-eslint#668 and jsx-eslint#686.
lencioni added a commit to lencioni/eslint-plugin-react that referenced this issue Jul 20, 2016
@lencioni
Rename wrap-multilines to jsx-wrap-multilines
601f2c2 
This rule is JSX-specific, not React-specific. Changing its name makes
this clearer. I've kept the old one around as deprecated. We can remove
it at the next major version bump.

Addresses jsx-eslint#686. Fixes jsx-eslint#668.
yannickcr pushed a commit that referenced this issue Jul 22, 2016
@lencioni @yannickcr
Rename some JSX-specific rules to include jsx- prefix (fixes #668)
57c6ccf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lencioni