Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-unknown-property: allow allowFullScreen on iframe #3455

Merged
merged 1 commit into from
Oct 10, 2022
Merged

no-unknown-property: allow allowFullScreen on iframe #3455

merged 1 commit into from
Oct 10, 2022

Conversation

almeidx
Copy link
Contributor

@almeidx almeidx commented Oct 10, 2022

@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

Merging #3455 (b42a0f3) into master (17858be) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3455   +/-   ##
=======================================
  Coverage   97.58%   97.58%           
=======================================
  Files         127      127           
  Lines        9068     9068           
  Branches     3308     3308           
=======================================
  Hits         8849     8849           
  Misses        219      219
Impacted Files Coverage Δ
lib/rules/no-unknown-property.js 98.82% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ljharb
ljharb approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb mentioned this pull request Oct 10, 2022
Closed
@ljharb ljharb force-pushed the no-unknown-property/iframe-allowfullscreen branch from 1093a96 to b42a0f3 Compare October 10, 2022 21:46
@ljharb ljharb merged commit b42a0f3 into jsx-eslint:master Oct 10, 2022
@ljharb
Copy link
Member

ljharb commented Oct 10, 2022

I'll be backporting this into a patch release of v7.31.10 shortly, before later publishing a v7.31.11 (which will also include this fix).

ljharb pushed a commit that referenced this pull request Oct 10, 2022
@almeidx @ljharb
[Fix] no-unknown-property: allow allowFullScreen on iframe (#3455)
74bfbc1 
Fixes #3456.
@ljharb
Copy link
Member

ljharb commented Oct 10, 2022

Published.

@almeidx almeidx deleted the no-unknown-property/iframe-allowfullscreen branch October 11, 2022 08:14
@ljharb ljharb mentioned this pull request Oct 11, 2022
Closed
@BuloZB BuloZB mentioned this pull request May 19, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request May 24, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request May 24, 2024
Open
This was referenced May 24, 2024
Open
Open
Open
@mjperrins mjperrins mentioned this pull request May 30, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Jun 3, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jun 3, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jun 3, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jun 3, 2024
Open
This was referenced Jun 3, 2024
Open
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jun 4, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Jun 5, 2024
Open
@paaschdigital paaschdigital mentioned this pull request Jun 7, 2024
Open
@MANAALHARBI MANAALHARBI mentioned this pull request Jun 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@almeidx @ljharb