[Fix] jsx-key: detect keys in logical expression and conditional expression
#3490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3490 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 129 129
Lines 9192 9200 +8
Branches 3331 3336 +5
=======================================
+ Hits 8969 8977 +8
Misses 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ljharb
force-pushed
the
jsx-key-fix-logical-and-conditional-expressions
branch
from
b3aac5f
to
d350a48
Compare
ljharb
changed the title
jsx-key: detect keys in logical expression and conditional expression
ljharb
pushed a commit
to ljharb/eslint-plugin-react
that referenced
this pull request
Nov 18, 2022
This was referenced May 24, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3481
I've also updated the docs to stay consistent with the comment from below
In the last example the key is being spread...