-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] jsx-boolean-value
: add assumeUndefinedIsFalse
option
#3675
[New] jsx-boolean-value
: add assumeUndefinedIsFalse
option
#3675
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3675 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 132 132
Lines 9383 9397 +14
Branches 3436 3445 +9
=======================================
+ Hits 9163 9177 +14
Misses 220 220 ☔ View full report in Codecov by Sentry. |
Yes, I think the second thing is a separate issue that should be fixed separately. |
0ee0a2b
to
3730edb
Compare
jsx-boolean-value
: add assumeUndefinedIsFalse
option
Fixes #3234
A new option has been added referring to the comments on this issue.
I think there are some parts that need explanation, so I'll list them below.
As you can see in the test case, if you remove both properties and values, a space remains, but that space can be modified with other rules such as jsx-props-no-multi-spaces, so it was left behind.
While adding new options, I noticed that there was some issue with the options in the error message. After setting never or always in the second option, if the modification is made not only to the first option but also to the second option, an error message containing the properties of the second option is displayed as shown below. If it is confirmed to be an issue, a new mr will be created after working on the current issue. An example is below: