Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumps deps; peerDeps allows ESLint 2 or 3 #657

Merged
merged 1 commit into from
Jul 5, 2016
Merged

bumps deps; peerDeps allows ESLint 2 or 3 #657

merged 1 commit into from
Jul 5, 2016

Conversation

jokeyrhyme
Copy link
Contributor

@jokeyrhyme jokeyrhyme commented Jul 2, 2016

  • specify ESLint 2 or 3 as a peerDependency to help npm users identify compatibility issues
  • specify Node.js 0.10 as the minimum (same as ESLint 2)

@ljharb
Copy link
Member

ljharb commented Jul 2, 2016

Wouldn't it be wiser to wait on updating the rule format, so there can be a version of the plugin that supports both eslint 2 and eslint 3 for awhile?

@jokeyrhyme
Copy link
Contributor Author

@ljharb my changes here are just a proposal of course, with the maintainers having final say. I made these changes assuming that the MAJOR SemVer number would be bumped, so ESLint 2 users could still use the previous version without any problems.

Do we want to continue making changes to the ESLint 2 version of this plugin? Or can we safely leave it as-is?

@ljharb
Copy link
Member

ljharb commented Jul 2, 2016

Yes, ideally we would keep making changes to the eslint "2 + 3" version for awhile, so as to give eslint 2 users (and node 0.10 users) as smooth an upgrade path as possible, for as long as possible. The only time this PR will become necessary is after eslint v4 comes out, so I'm inclined not to rush it.

@jokeyrhyme
Copy link
Contributor Author

Okay. If I get time later, I'll change this PR to keep the old ESLint 2 rule format. Or, someone else can beat me to it by creating a less turbulent PR. :)

@jokeyrhyme
Copy link
Contributor Author

@ljharb okies, I've removed all rule format changes, this is purely about enabling usage with ESLint 3 without touching existing support for ESLint 2

@jokeyrhyme jokeyrhyme changed the title bumps deps; use ESLint 3 rule format bumps deps; peerDeps allows ESLint 2 or 3 Jul 3, 2016
@@ -27,12 +27,18 @@
"jsx-ast-utils": "^1.2.1"
},
"devDependencies": {
"babel-eslint": "6.0.5",
"babel-eslint": "^6.0.5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this not be bumped to 6.1.0?

@ljharb
Copy link
Member

ljharb commented Jul 3, 2016

LGTM

@elliottsj
Copy link

What's blocking this from being merged?

@ljharb ljharb merged commit c1c8872 into jsx-eslint:master Jul 5, 2016
@ljharb
Copy link
Member

ljharb commented Jul 5, 2016

@yannickcr it'd be great to get a release of this :-)

@jokeyrhyme jokeyrhyme deleted the bump-deps-eslint-3 branch July 5, 2016 19:10
@yannickcr
Copy link
Member

@ljharb Thanks for your help, I'm a bit late on this :( I'll try to do a release tomorrow.

@ljharb
Copy link
Member

ljharb commented Jul 5, 2016

@yannickcr thanks! looking forward to releasing a new eslint-config-airbnb ;-)

@ljharb
Copy link
Member

ljharb commented Jul 7, 2016

@jokeyrhyme turns out eslint v2 supports the new rule format already (import-js/eslint-plugin-import#406 (comment)) so if you'd like to make a new PR that upgrades the rules, id be happy to merge it :-)

@jokeyrhyme
Copy link
Contributor Author

@ljharb woah, that's really good planning on ESLint's part. I'll see how extra-curricular I'm feeling this weekend. :)

@yannickcr
Copy link
Member

@ljharb Since adding a peerDepencency is a big change I prefer to consider it as a breaking change.

I am not ready yet to publish the v6.0.0 (I'd like to add a few more waiting changes in it) so I published it as v6.0.0-alpha.1. You can install it with npm install eslint-plugin-react@next.

@ljharb
Copy link
Member

ljharb commented Jul 8, 2016

@yannickcr understood - in this case I don't think anybody is still using eslint v1 with eslint-plugin-react, but it's good to be cautious. I won't be able to release an updated eslint-config-airbnb without a non-alpha eslint-plugin-react anyways, but as you can see I've got a few more blockers, so within the next week or so would be ideal if that's ok :-)

@jokeyrhyme
Copy link
Contributor Author

Do you have a GitHub Milestone for 6.0, or a list somewhere? Want some help?

@yannickcr
Copy link
Member

@ljharb @jokeyrhyme I do not have a lot of time this week but I'll try to do an roadmap before the week-end (like I made for 4.0 #436)

@yannickcr yannickcr mentioned this pull request Jul 17, 2016
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants