Remove rules deprecated options #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option was deprecated in a previous version in favor of putting this in a shared setting. Now that we are preparing for a major version bump, we want to clean this out.
This option was deprecated in a previous version in favor of putting this in a shared setting. Now that we are preparing for a major version bump, we want to clean this out.
| }, | ||
| additionalProperties: false | ||
| }]; | ||
| module.exports.schema = []; |
There was a problem hiding this comment.
if you supply an option when the schema is [], does it error out? ie, does it have additionalProperties: false behavior implicitly?
There was a problem hiding this comment.
I just tried this out with a different rule that has a schema of [] and it produced an error like:
Configuration for rule "plugin/rule" is invalid:
Value "config value" has more items than allowed.
There was a problem hiding this comment.
Awesome, thanks for confirming :-)
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These options were deprecated in a previous release. Now that we are preparing for a major version bump, we want to clear them out.
Addresses #686.