chartjs-2.0 Hardcoded property "fill" in getDataSets

[courchef]

The property fill is hardcoded to true in function getDataSets

    function getDataSets (labels, data, series, colors) {
      return {
        labels: labels,
        datasets: data.map(function (item, i) {
          return angular.extend({}, colors[i], {
            label: series[i],
            data: item,
            fill: true
          });
        })
      };
    }

Is it possible to convert this into an option?

[courchef]

In my cshtml file, I added a tag named chart-fill

<canvas id="primary" class="chart chart-line" chart-fill="false"></canvas>

In the ChartJsFactory, I added the property in the scope:

        scope: {
          getColour: '=?',
          chartType: '=',
          chartData: '=?',
          chartLabels: '=?',
          chartOptions: '=?',
          chartSeries: '=?',
          chartColors: '=?',
          chartFill: '=',
          chartLocale: '=?',
          chartClick: '=?',
          chartHover: '=?'
        },

In method getDataSets and getData, I added a fill parameter instead of the hardcoded value:

    function getDataSets (labels, data, series, colors, fill) {
      return {
        labels: labels,
        datasets: data.map(function (item, i) {
          return angular.extend({}, colors[i], {
            label: series[i],
            data: item,
            fill: fill
          });
        })
      };
    }

And finally, when calling getDataSets or getData, I add the scope property chartFill:

            var data = Array.isArray(scope.chartData[0]) ?
              getDataSets(scope.chartLabels, scope.chartData, scope.chartSeries || [], scope.chartColors, scope.chartFill) :
              getData(scope.chartLabels, scope.chartData, scope.chartColors, scope.chartFill);

What do you think?

[jtblin]

Thanks. Agreed it should not be hardcoded. Looking at the 2.0 docs, it is possible to set the value via standard Chart.js options and it already defaults to true so I've just removed it.

https://github.com/nnnick/Chart.js/blob/v2.0-dev/docs/00-Getting-Started.md

[courchef]

I removed all my modifications, updated to your last commit and set fill: false in default options of Chart.js

Many thanks for your work!

[jtblin]

👍

[seralf]

Hi the correct link seems to be:
https://github.com/chartjs/Chart.js/blob/master/docs/00-Getting-Started.md