Fix missing redirect on m5/c5 instances #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS metadata service works differently on new instance types like m5.large and c5.large. The behavior on old instances is that if you call: ``` 169.254.169.254/latest/meta-data/iam/security-credentials ``` It will redirect to: ``` 169.254.169.254/latest/meta-data/iam/security-credentials/ ``` Which will respond with the IAM role name. On new instances there is no redirect, it just responds with the IAM role name directly. Since kube2iam didn't intercept the URL without the slash, the pod will initially get the worker node role and then try to request credentials for that role, which kube2iam will deny. Fix is to intercept both versions of the URL. Fix jtblin#127
mikkeloscar
force-pushed
the
fix-redirect-m5-c5
branch
from
1f2da6c
to
2650652
Compare
This was referenced Mar 14, 2018
This was referenced Mar 26, 2018
This was referenced May 31, 2018
eaceaser
pushed a commit
to eaceaser/kube2iam
that referenced
this pull request
Jun 12, 2018
The AWS metadata service works differently on new instance types like m5.large and c5.large. The behavior on old instances is that if you call: ``` 169.254.169.254/latest/meta-data/iam/security-credentials ``` It will redirect to: ``` 169.254.169.254/latest/meta-data/iam/security-credentials/ ``` Which will respond with the IAM role name. On new instances there is no redirect, it just responds with the IAM role name directly. Since kube2iam didn't intercept the URL without the slash, the pod will initially get the worker node role and then try to request credentials for that role, which kube2iam will deny. Fix is to intercept both versions of the URL. Fix jtblin#127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS metadata service works differently on new instance types like
m5.large and c5.large.
The behavior on old instances is that if you call:
It will redirect to:
Which will respond with the IAM role name.
On new instances there is no redirect, it just responds with the IAM role name directly.
Since kube2iam didn't intercept the URL without the slash, the pod will
initially get the worker node role and then try to request credentials for that
role, which kube2iam will deny.
Fix is to intercept both versions of the URL.
Fix #127