Replace keybinding name fromJust with maybe #511
Conversation
src/Brick/Keybindings/Pretty.hs
Outdated
| @@ -124,7 +124,7 @@ mkKeybindEventHelp kc h = | |||
| ByKey b -> | |||
| (Comment "(non-customizable key)", [Verbatim $ ppBinding b]) | |||
| ByEvent ev -> | |||
| let name = fromJust $ keyEventName (keyConfigEvents kc) ev | |||
| let name = fromMaybe "<unnamed>" $ keyEventName (keyConfigEvents kc) ev | |||
There was a problem hiding this comment.
@jtdaugherty I don't understand why this failed for me - I do not see <unnamed> in the output.
There was a problem hiding this comment.
I must have missed one event in KeyEvents and then fixed it before creating this PR.
I deleted one, and the text is shown now:
| Keybinding | Event Name | Description |
| ---------- | ---------- | ----------- |
| `C-q` | (unnamed) | Open quit game dialog |
xsebek
force-pushed
the
keybinding-name-from-just
branch
from
7c84b2c
to
7015b40
Compare
xsebek
changed the title
|
I'm a little confused - could you provide some context for this patch? The commit message does not provide a motivation for it, so I don't know what problem this is intended to solve. |
|
@jtdaugherty I updated the description. 👍 Simply put I run into a |
|
Oh, so the higher-level problem is that you had a key event in existence that was not in the |
|
Thanks for your patch! |
|
This is now released in 2.3.2. |
When I forgot a
KeyEventsentry and tried to print all keybindings, thefromJustfailed with an error that does not show the problematic handler.Instead of erroring out, write
(unnamed)into Event Name, so that it's easy to see which handler is missing a name.