Add optional default_extra param to formatter initializer.
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is used to specify extra parameters that are valid for all log
messages formatted with the formatter. It is usefull to avoid repeting
`extra={...}` in every log call.
|
@matteo-zanoni thank you for your pr. I will test it today, also I will update with tests and documentation before merge. |
|
@jteppinette happy to help with any of those tasks... Just looking for some guidance I guess |
The _old_ way described in the docs is now deprecated since the `default_extra` parameter achieves the same outcome in a more clean and explicit way.
|
@jteppinette I have updated the documentation and added simple tests for the new behaviour. Hoping this can be helpful |
|
Hi @jteppinette have you been able to review this PR? Can I help with anything to get this merged and released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to specify extra parameters that are valid for all log messages formatted with the formatter. It is usefull to avoid repeting
extra={...}in every log call.Closes #11