Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: getStaticDirectory() removal breaks build #192

Closed
pham opened this issue Dec 1, 2022 · 0 comments · Fixed by #193
Closed

bug: getStaticDirectory() removal breaks build #192

pham opened this issue Dec 1, 2022 · 0 comments · Fixed by #193
Labels
bug Something isn't working

Comments

@pham
Copy link
Contributor

pham commented Dec 1, 2022

Describe the Bug

SvelteKit removed getStaticDirectory() function in sveltejs/kit#7809 breaks the build.

Steps to Reproduce

  1. Build the project

Spits out errors:

> Using svelte-adapter-firebase
error during build:
TypeError: builder.getStaticDirectory is not a function
 at adapt (file:///./node_modules/.pnpm/file+..+svelte-adapter-firebase_u7k3ayrbkw2qngmchevq6cz5qu/node_modules/svelte-adapter-firebase/src/index.js:28:77)

Expected Behaviour

> Using svelte-adapter-firebase
  ✔ done

svelte-adapter-firebase version

0.14.4

sveltejs/kit version

1.0.0-next.570
@pham pham added the bug Something isn't working label Dec 1, 2022
pham added a commit to pham/svelte-adapter-firebase that referenced this issue Dec 1, 2022
@pham
fix(jthegedus#192): Switch from getStaticDirectory() to `builder.co…
f1fb314 
…nfig.kit.files.assets`
@pham pham mentioned this issue Dec 1, 2022
Merged
@github-actions github-actions bot mentioned this issue Dec 14, 2022
Closed
@github-actions github-actions bot mentioned this issue Jan 13, 2023
Open
pham added a commit to pham/svelte-adapter-firebase that referenced this issue Jan 15, 2023
@pham
fix(jthegedus#192): Switch from getStaticDirectory() to `builder.co…
fc02d8f 
…nfig.kit.files.assets`
@github-actions github-actions bot mentioned this issue Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#192): replace getStaticDirectory with kit.files.assets pham/svelte-adapter-firebase
1 participant
@pham