Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#172): Remove reference to obsoleted writeStatic #173

Merged
merged 5 commits into from
Aug 7, 2022
Merged

fix(#172): Remove reference to obsoleted writeStatic #173

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d5760ca
fix(#172): Remove reference to obsoleted `writeStatic`
pham Jul 20, 2022
f1d6d17
chore: release 0.14.2
github-actions[bot] Jul 20, 2022
98c24f5
Merge pull request #5 from pham/release-v0.14.2
pham Jul 20, 2022
7db609c
chore: revert version changes
jthegedus Aug 7, 2022
6e26aee
chore: revert manual changelog updates
jthegedus Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ const entrypoint = function (options = {}) {
builder.rimraf(publicDir);

builder.log.minor(logRelativeDir('Writing client application to', publicDir));
builder.writeStatic(publicDir);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this replaced with anything? How are these files now being written?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I'm just experimenting with the adapter, but stuck on this error. Any guidance? Just wait for this to be resolved? pin to an earlier version of SvelteKit? Thoughts? Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like it was replaced with anything else on the adapter-vercel
sveltejs/kit@8191720

I'll give this a try.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to PR5618:

Have writeClient write both the client and static files and remove writeStatic. This is a breaking change for adapter authors.

writeClient does job for writeStatic so I removed writeStatic.

builder.writeClient(publicDir);

builder.log.minor(logRelativeDir('Prerendering static pages to', publicDir));
Expand Down