Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"FileBasedEventStorageCustomLocationTest" test not passed in Windows #49

Merged
merged 4 commits into from
Jun 7, 2016

Conversation

mahmoodm2
Copy link
Contributor

The current "FileBasedEventStorageCustomLocationTest " unit test uses "base-context-custom-files.xml" resource file as its application context. In the resource file the default TEMP directory assumed to be /tmp which is not compatible with Windows.

To solve this, the corresponding property(filePath) setting in .xml file was removed and instead the temp directory was prepared in the test class.
This change passed all tests: "mvn test"

@jtmelton
Copy link
Owner

jtmelton commented Jun 7, 2016

Nice work @mahmoodm2, and thank you.

@jtmelton jtmelton merged commit c2b81be into jtmelton:master Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants