Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rest of Title API #125

Merged
merged 4 commits into from
Aug 9, 2023
Merged

Add rest of Title API #125

merged 4 commits into from
Aug 9, 2023

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Aug 8, 2023 •
edited
Loading

References

Code Changes

  • add caption, class_name, dataset, icon_label

    • not mnemonic, didn't seem to do anything

  • add to icons example notebook
  • run lint against jupyterlab 3

User-facing Changes

A user can now customize a Panel's title appearance more substantially

image

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

Binder 👈 Try it on Binder (branch bollwyvl/ipylab/gh-124-title-api)

@bollwyvl bollwyvl marked this pull request as ready for review August 8, 2023 17:36
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Aug 8, 2023

Re: the lint failure: could pin the build infra to jupyterlab <4 for now?

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Aug 8, 2023

Maybe iconLabel and mnemonic have no effect outside of menus?

@jtpio jtpio added the enhancement New feature or request label Aug 9, 2023
@jtpio
Copy link
Owner

jtpio commented Aug 9, 2023 •
edited
Loading

Re: the lint failure: could pin the build infra to jupyterlab <4 for now?

Yes makes sense 👍

We can do the JupyterLab 4 update separately.

jtpio
jtpio approved these changes Aug 9, 2023
View reviewed changes
Copy link
Owner

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit b1ecc2c into jtpio:main Aug 9, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete rest of Title API
2 participants
@bollwyvl @jtpio