Various improvements re character encoding and testing #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 8, 2013 14:23
As a side-effect, this makes us use unicode, which will be useful for non-ascii characters in aythor and story names down the line.
Just to prove that my initial changes work.
Python doesn't let us know the terminal encoding if we're piping (which may or may not be correct, depending on who you ask). So we need some extra handling. Incidentally, handling the output differently also makes is easier to test that we're getting the right output. I've only implemented this for show_stories thus far.
Fetching and displaying information are two distinct tasks, one of which is functional.
Also basic testing and separation of concerns.
Seeing these is useful in some workflows,
|
I've tested here and the story title stills bad. I received the unicode error on |
|
yay -- pull request -- I will review shortly |
|
(and sorry I did not see this earlier) |
Apparently, ElementTree likes to do it's own decoding. It raises a UnicodeError when given the decoded response.text, but it works fine when given the raw response.content.
Use the binary response content instead of unicode
|
So I know that this pull hasn't been merged or accepted yet but I just downloaded the fork and it makes something that doesn't work, work! You should probably merge this 😄 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are mostly improvements I needed myself, but they're relevant for #7, #9 and #10.