-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #69 #70
Issue #69 #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test.
As the application is using the Native OS File Dialog for the file upload, it seems we cannot test this functionality through TestFX. Hence I added a unit test for the null check. Please check. |
can u check the build failures? |
I think the build errors are due to the new dependencies in the previous PR below #67 (comment) The dependencies are downloaded without any problem and the build is fine on my Local. Should we change anything in the Travis CI ? |
have u tried clean install |
It seems travis build is unable to resolve Loggable annotation. /home/travis/build/jughyd/GitFx/src/main/java/io/github/gitfx/controller/GitFxController.java:54: error: package com.jcabi.aspects does not exist |
Yes, the Clean Install is fine on my machine. |
Merging for now as the build is clean. |
Fixed NullPointer Exception when clicked on Cancel button in the FileDialog