Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #69 #70

Merged
merged 4 commits into from
Feb 6, 2017
Merged

Issue #69 #70

merged 4 commits into from
Feb 6, 2017

Conversation

SaiUpadhyayula
Copy link
Contributor

Fixed NullPointer Exception when clicked on Cancel button in the FileDialog

Fixed NullPointer Exception when clicked on Cancel button in the FileDialog
Copy link
Member

@rohitvvv rohitvvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test.

@SaiUpadhyayula
Copy link
Contributor Author

As the application is using the Native OS File Dialog for the file upload, it seems we cannot test this functionality through TestFX.

Hence I added a unit test for the null check.

Please check.

@jbuddha
Copy link
Member

jbuddha commented Feb 6, 2017

can u check the build failures?

@SaiUpadhyayula
Copy link
Contributor Author

I think the build errors are due to the new dependencies in the previous PR below #67 (comment)

The dependencies are downloaded without any problem and the build is fine on my Local.

Should we change anything in the Travis CI ?

@jbuddha
Copy link
Member

jbuddha commented Feb 6, 2017

have u tried clean install

@rohitvvv
Copy link
Member

rohitvvv commented Feb 6, 2017

It seems travis build is unable to resolve Loggable annotation.
https://travis-ci.org/jughyd/GitFx/builds/198787540

/home/travis/build/jughyd/GitFx/src/main/java/io/github/gitfx/controller/GitFxController.java:54: error: package com.jcabi.aspects does not exist
import com.jcabi.aspects.Loggable;

@SaiUpadhyayula
Copy link
Contributor Author

Yes, the Clean Install is fine on my machine.

@rohitvvv
Copy link
Member

rohitvvv commented Feb 6, 2017

Merging for now as the build is clean.

@rohitvvv rohitvvv closed this Feb 6, 2017
@rohitvvv rohitvvv reopened this Feb 6, 2017
@rohitvvv rohitvvv merged commit 4cc21bf into jughyd:develop Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants