-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add button to reset passcode #64
Conversation
Wow nice 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be working great 👏
If marked some minor spots where you are using sync code where it could be written asynchronously.
One thing we could potentially change to make this more flexible is to change the resetPasscode
endpoint to accept the team name as a request argument. This way we could also use the endpoint on the admin page so that an admin can change the passcode of a team.
But this should be flexible enough for now 👍
Merged and released with v3.8.0 Thanks again, much appropriated 🙌 (I've added the hacktoberfest-accepted label to the pr in case you are participating in that) |
Great, thanks! I started to extend the reset-password endpoint for the admin user too. However, I couldn't really find space in the admin table to display the new code 😄 |
I did some work on #63:
The PR adds a new button to the
<TeamDisplayCard />
.Clicking it will generate a new passcode, patch the teams juice-shop deployment with the new hash and return the passcode to the user. The passcode will then be displayed via the old but modified
<PasscodeDisplayCard />
.Looking forward to your feedback!