on Windows platform, Paths.get(jarPath) will get InvalidPathException…

… like "java.nio.file.InvalidPathException: Illegal char <:> at index 2: /C:/Program Files/xxx"，change to use Paths.get(location.toURI()) (#3907)
juicedata · Jul 17, 2023 · 1767c51 · 1767c51
1 parent d7bcecc
commit 1767c51
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/sdk/java/src/main/java/io/juicefs/JuiceFileSystemImpl.java b/sdk/java/src/main/java/io/juicefs/JuiceFileSystemImpl.java
@@ -620,14 +620,19 @@ public static Libjfs loadLibrary() throws IOException {
       soTime = entry.getLastModifiedTime().toMillis();
       ins = jfsJar.getInputStream(entry);
     } else {
-      String jarPath = URLDecoder.decode(location.getPath(), Charset.defaultCharset().name());
-      if (Files.isDirectory(Paths.get(jarPath))) { // for debug: sdk/java/target/classes
+      URI locationUri;
+      try {
+        locationUri = location.toURI();
+      } catch (URISyntaxException e) {
+        return loadExistLib(libjfsLibraryLoader, dir, name, libFile);
+      }
+      if (Files.isDirectory(Paths.get(locationUri))) { // for debug: sdk/java/target/classes
         soTime = con.getLastModified();
         ins = JuiceFileSystemImpl.class.getClassLoader().getResourceAsStream(resource);
       } else {
         JarFile jfsJar;
         try {
-          jfsJar = new JarFile(jarPath);
+          jfsJar = new JarFile(locationUri.getPath());
         } catch (FileNotFoundException fne) {
           return loadExistLib(libjfsLibraryLoader, dir, name, libFile);
         }