Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The --io-retries option doesn't seem to work correctly #1413

Closed
xiaogaozi opened this issue Feb 11, 2022 · 1 comment · Fixed by #1713
Closed

The --io-retries option doesn't seem to work correctly #1413

xiaogaozi opened this issue Feb 11, 2022 · 1 comment · Fixed by #1713
Labels
kind/feature New feature or request pending Solution to this issue is not decided
Milestone
Release 1.0

Comments

@xiaogaozi
Copy link
Member

What would you like to be added:

The --io-retries option should be able to control the number of retries for all IO requests, including read and write data to data storage and metadata engine.

Currently, the maxRetries of dataReader and dataWriter is equal to conf.Meta.Retries, and conf.Meta.Retries is hard coded to 10 (like here).

Why is this needed:

User need to be able to control the number of retries of IO requests.
@xiaogaozi xiaogaozi added the kind/feature New feature or request label Feb 11, 2022
@SandyXSD
Copy link
Contributor

Confirmed, this option is ignored for now.
There are several kind of retries in the IO procedure; we should rethink about them and make the option more clear.

@SandyXSD SandyXSD mentioned this issue Feb 21, 2022
Closed
@SandyXSD SandyXSD added the pending Solution to this issue is not decided label Feb 24, 2022
@davies davies added this to the Release 1.0 milestone Mar 18, 2022
@SandyXSD SandyXSD mentioned this issue Apr 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature New feature or request pending Solution to this issue is not decided
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging a pull request may close this issue.

Set max retries of meta & chunk according to the config io-retries juicedata/juicefs
3 participants
@davies @xiaogaozi @SandyXSD