Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set max retries of meta & chunk according to the config io-retries #1713

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Apr 2, 2022

close #1413

@codecov-commenter
Copy link

Codecov Report

Merging #1713 (9052c3f) into main (ce93bea) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   61.62%   61.78%   +0.15%     
==========================================
  Files         135      135              
  Lines       22872    22879       +7     
==========================================
+ Hits        14096    14136      +40     
+ Misses       7179     7149      -30     
+ Partials     1597     1594       -3     
Impacted Files Coverage Δ
cmd/flags.go 95.48% <100.00%> (ø)
cmd/mount.go 70.72% <100.00%> (+0.13%) ⬆️
pkg/chunk/cached_store.go 80.40% <100.00%> (+3.04%) ⬆️
pkg/meta/base.go 71.69% <100.00%> (+0.50%) ⬆️
pkg/meta/utils.go 71.18% <0.00%> (-0.49%) ⬇️
pkg/meta/sql.go 67.02% <0.00%> (ø)
pkg/chunk/disk_cache.go 80.33% <0.00%> (+0.48%) ⬆️
pkg/vfs/writer.go 79.66% <0.00%> (+1.01%) ⬆️
pkg/vfs/reader.go 81.56% <0.00%> (+1.27%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce93bea...9052c3f. Read the comment docs.

@davies davies merged commit b5a4a6e into main Apr 6, 2022
@davies davies deleted the fix-io-retries branch April 6, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --io-retries option doesn't seem to work correctly
3 participants