-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up dump for sql engine #1006
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1006 +/- ##
============================================
+ Coverage 37.20% 37.33% +0.12%
Complexity 33 33
============================================
Files 146 146
Lines 23560 23682 +122
Branches 422 422
============================================
+ Hits 8766 8841 +75
- Misses 13617 13651 +34
- Partials 1177 1190 +13
Continue to review full report at Codecov.
|
pkg/meta/sql.go
Outdated
if err != nil { | ||
return nil, err | ||
return err |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we skip the edge and continue (log it as warning)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has been modified
2. Skip the case where entry is equal to nil
…l show estimated arrival time Fix the problem that the SQL statement of a single submission is too long, which causes the placeholder to exceed the upper limit
Performance Testingdata and env:
result:old version
new version
Test conclusion
|
Speed up for dbmeta