Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a option to provide customized bucket endpoint #1008

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conversation

davies
Copy link
Contributor

@davies davies commented Nov 17, 2021

Closes #1003

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2021

Codecov Report

Merging #1008 (c121edf) into main (630263d) will increase coverage by 2.59%.
The diff coverage is 18.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1008      +/-   ##
============================================
+ Coverage     37.20%   39.79%   +2.59%     
- Complexity       33      149     +116     
============================================
  Files           146      146              
  Lines         23560    23563       +3     
  Branches        422      422              
============================================
+ Hits           8766     9378     +612     
+ Misses        13617    12891     -726     
- Partials       1177     1294     +117     
Impacted Files Coverage Δ
cmd/gateway.go 0.00% <0.00%> (ø)
cmd/mount.go 0.00% <0.00%> (ø)
.../src/main/java/io/juicefs/JuiceFileSystemImpl.java 57.19% <66.66%> (+57.19%) ⬆️
...java/src/main/java/io/juicefs/JuiceFileSystem.java 79.59% <0.00%> (-2.23%) ⬇️
pkg/meta/sql.go 66.51% <0.00%> (-0.56%) ⬇️
pkg/meta/redis_metrics.go
pkg/meta/metrics.go 0.00% <0.00%> (ø)
pkg/meta/redis.go 69.32% <0.00%> (+0.16%) ⬆️
pkg/vfs/handle.go 77.31% <0.00%> (+0.84%) ⬆️
pkg/vfs/writer.go 75.93% <0.00%> (+1.01%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 630263d...c121edf. Read the comment docs.

@davies davies requested a review from SandyXSD November 18, 2021 03:27
@davies davies merged commit 454e072 into main Nov 18, 2021
@davies davies deleted the custom_bucket branch November 18, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support overwrite object storage endpoint URL when mount file system
2 participants