Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: always call setproctitle #1361

Merged
merged 1 commit into from
Jan 29, 2022
Merged

cmd: always call setproctitle #1361

merged 1 commit into from
Jan 29, 2022

Conversation

SandyXSD
Copy link
Contributor

We have to always call the gspt.SetProcTitle to adjust the title, or it will be reset to args[0] after the gspt package initialized.
See: https://github.com/erikdubbelboer/gspt/blob/ce36a5128377/gspt.go#L55

@codecov-commenter
Copy link

Codecov Report

Merging #1361 (66602dd) into main (5c6d557) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1361      +/-   ##
==========================================
+ Coverage   59.41%   59.61%   +0.19%     
==========================================
  Files         128      128              
  Lines       21663    21670       +7     
==========================================
+ Hits        12872    12918      +46     
+ Misses       7254     7205      -49     
- Partials     1537     1547      +10     
Impacted Files Coverage Δ
cmd/main.go 56.12% <100.00%> (+0.51%) ⬆️
cmd/bench.go 78.78% <0.00%> (-1.35%) ⬇️
pkg/meta/tkv.go 75.44% <0.00%> (-0.75%) ⬇️
pkg/chunk/disk_cache.go 80.29% <0.00%> (+1.47%) ⬆️
pkg/chunk/cached_store.go 73.18% <0.00%> (+2.42%) ⬆️
cmd/mount_unix.go 54.23% <0.00%> (+6.77%) ⬆️
cmd/gc.go 64.76% <0.00%> (+15.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c6d557...66602dd. Read the comment docs.

@davies davies merged commit f3f0b04 into main Jan 29, 2022
@davies davies deleted the fix-proctitle branch January 29, 2022 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants