cmd: print usage if not enough args #1491

SandyXSD · 2022-02-28T09:37:34Z

No description provided.

codecov-commenter · 2022-02-28T10:09:38Z

Codecov Report

Merging #1491 (db1f36f) into main (be0a8fc) will increase coverage by 0.10%.
The diff coverage is 71.87%.

@@            Coverage Diff             @@
##             main    #1491      +/-   ##
==========================================
+ Coverage   59.72%   59.83%   +0.10%     
==========================================
  Files         132      132              
  Lines       22170    22132      -38     
==========================================
+ Hits        13241    13242       +1     
+ Misses       7368     7346      -22     
+ Partials     1561     1544      -17

Impacted Files	Coverage Δ
cmd/destroy.go	`14.28% <0.00%> (+0.21%)`	⬆️
cmd/gateway.go	`33.33% <0.00%> (+0.56%)`	⬆️
cmd/profile.go	`15.70% <0.00%> (+0.11%)`	⬆️
cmd/stats.go	`20.07% <0.00%> (+0.15%)`	⬆️
cmd/webdav.go	`74.35% <0.00%> (+6.91%)`	⬆️
cmd/main.go	`48.86% <66.66%> (-1.72%)`	⬇️
cmd/bench.go	`80.06% <100.00%> (+0.51%)`	⬆️
cmd/config.go	`68.12% <100.00%> (+0.84%)`	⬆️
cmd/dump.go	`78.04% <100.00%> (+3.63%)`	⬆️
cmd/format.go	`64.84% <100.00%> (+0.99%)`	⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be0a8fc...db1f36f. Read the comment docs.

davies · 2022-02-28T13:27:47Z

cmd/warmup.go

@@ -102,6 +102,7 @@ func sendCommand(cf *os.File, batch []string, count int, threads uint, backgroun
 }

 func warmup(ctx *cli.Context) error {
+	setup(ctx, 0)


If warmup with -f option, the positional argument is not necessary.

cmd: print usage if not enough args

6572d4c

SandyXSD requested a review from davies February 28, 2022 09:37

only shows command usage

db1f36f

SandyXSD force-pushed the fix-cmd-usage branch from 099b1b5 to db1f36f Compare February 28, 2022 13:10

davies reviewed Feb 28, 2022

View reviewed changes

davies merged commit 632953a into main Feb 28, 2022

davies deleted the fix-cmd-usage branch February 28, 2022 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd: print usage if not enough args #1491

cmd: print usage if not enough args #1491

SandyXSD commented Feb 28, 2022

codecov-commenter commented Feb 28, 2022 •

edited

Loading

davies Feb 28, 2022

SandyXSD Feb 28, 2022

davies Feb 28, 2022

cmd: print usage if not enough args #1491

cmd: print usage if not enough args #1491

Conversation

SandyXSD commented Feb 28, 2022

codecov-commenter commented Feb 28, 2022 • edited Loading

Codecov Report

davies Feb 28, 2022

Choose a reason for hiding this comment

SandyXSD Feb 28, 2022

Choose a reason for hiding this comment

davies Feb 28, 2022

Choose a reason for hiding this comment

codecov-commenter commented Feb 28, 2022 •

edited

Loading