Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add umask for s3 gateway and refactor code #1537

Merged
merged 1 commit into from
Mar 9, 2022
Merged

add umask for s3 gateway and refactor code #1537

merged 1 commit into from
Mar 9, 2022

Conversation

zhijian-pro
Copy link
Contributor

No description provided.

@zhijian-pro zhijian-pro marked this pull request as ready for review March 9, 2022 05:30
@codecov-commenter
Copy link

Codecov Report

Merging #1537 (bb01c5a) into main (78b11ae) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
- Coverage   61.29%   61.25%   -0.04%     
==========================================
  Files         133      133              
  Lines       22269    22277       +8     
==========================================
- Hits        13650    13646       -4     
- Misses       7078     7087       +9     
- Partials     1541     1544       +3     
Impacted Files Coverage Δ
pkg/gateway/gateway.go 46.36% <66.66%> (ø)
cmd/gateway.go 87.30% <77.77%> (-0.84%) ⬇️
pkg/meta/tkv.go 75.44% <0.00%> (-0.77%) ⬇️
pkg/meta/redis.go 72.78% <0.00%> (-0.23%) ⬇️
pkg/meta/sql.go 67.06% <0.00%> (-0.11%) ⬇️
pkg/vfs/reader.go 83.39% <0.00%> (+1.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ae2e9f...bb01c5a. Read the comment docs.

@zhijian-pro zhijian-pro requested a review from davies March 9, 2022 06:57
@davies davies merged commit 5ef69e8 into juicedata:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants