Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: encrypt the secret-key and encrypt-key in setting #1562

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Conversation

SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Mar 11, 2022

  1. set secret-key again using config command will make keys encrypted
  2. once encrypted, old client is unable to connect to the data storage again

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #1562 (ae00eea) into main (012bc88) will decrease coverage by 0.16%.
The diff coverage is 48.38%.

❗ Current head ae00eea differs from pull request most recent head 239c497. Consider uploading reports for the commit 239c497 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1562      +/-   ##
==========================================
- Coverage   61.28%   61.11%   -0.17%     
==========================================
  Files         133      133              
  Lines       22273    22365      +92     
==========================================
+ Hits        13650    13669      +19     
- Misses       7078     7145      +67     
- Partials     1545     1551       +6     
Impacted Files Coverage Δ
cmd/destroy.go 14.28% <0.00%> (ø)
cmd/format.go 59.66% <20.00%> (-1.46%) ⬇️
pkg/meta/config.go 36.00% <37.03%> (+2.66%) ⬆️
cmd/config.go 67.26% <77.77%> (-0.62%) ⬇️
pkg/meta/redis.go 72.47% <80.00%> (-0.23%) ⬇️
pkg/meta/sql.go 66.71% <80.00%> (-0.46%) ⬇️
pkg/meta/tkv.go 76.08% <80.00%> (+0.64%) ⬆️
cmd/fsck.go 68.36% <100.00%> (ø)
cmd/gateway.go 87.30% <100.00%> (ø)
cmd/gc.go 78.92% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 484a6de...239c497. Read the comment docs.

@SandyXSD SandyXSD marked this pull request as ready for review March 11, 2022 09:57
@SandyXSD SandyXSD requested a review from davies March 11, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants