Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Go 1.17 #1594

Merged
merged 1 commit into from
Mar 17, 2022
Merged

switch to Go 1.17 #1594

merged 1 commit into from
Mar 17, 2022

Conversation

davies
Copy link
Contributor

@davies davies commented Mar 17, 2022

Go 1.18 is released and 1.16 is also deprecated, we should upgrade it to 1.17.

@codecov-commenter
Copy link

Codecov Report

Merging #1594 (23c2b04) into main (f78f922) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1594      +/-   ##
==========================================
- Coverage   61.33%   61.26%   -0.07%     
==========================================
  Files         133      133              
  Lines       22424    22424              
==========================================
- Hits        13753    13738      -15     
- Misses       7113     7125      +12     
- Partials     1558     1561       +3     
Impacted Files Coverage Δ
pkg/chunk/utils_unix.go 73.33% <0.00%> (-20.00%) ⬇️
pkg/vfs/reader.go 81.56% <0.00%> (-3.11%) ⬇️
pkg/meta/sql.go 67.13% <0.00%> (ø)
pkg/meta/redis.go 72.99% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78f922...23c2b04. Read the comment docs.

@davies davies merged commit 2aff73e into main Mar 17, 2022
@davies davies deleted the go117.2 branch March 17, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants