Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: forbid empty name for dentry #1687

Merged
merged 2 commits into from
Apr 1, 2022
Merged

meta: forbid empty name for dentry #1687

merged 2 commits into from
Apr 1, 2022

Conversation

SandyXSD
Copy link
Contributor

No description provided.

@SandyXSD SandyXSD marked this pull request as draft March 30, 2022 10:35
@codecov-commenter
Copy link

Codecov Report

Merging #1687 (ef8476b) into main (5284e15) will increase coverage by 0.05%.
The diff coverage is 0.00%.

❗ Current head ef8476b differs from pull request most recent head 9e5d180. Consider uploading reports for the commit 9e5d180 to get more accurate results

@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
+ Coverage   61.71%   61.76%   +0.05%     
==========================================
  Files         134      134              
  Lines       22651    22657       +6     
==========================================
+ Hits        13978    13994      +16     
+ Misses       7101     7091      -10     
  Partials     1572     1572              
Impacted Files Coverage Δ
pkg/meta/base.go 72.02% <0.00%> (-0.40%) ⬇️
pkg/vfs/writer.go 78.64% <0.00%> (-1.02%) ⬇️
pkg/meta/sql.go 67.08% <0.00%> (ø)
pkg/chunk/disk_cache.go 80.33% <0.00%> (ø)
pkg/vfs/reader.go 84.67% <0.00%> (+3.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5284e15...9e5d180. Read the comment docs.

@SandyXSD SandyXSD marked this pull request as ready for review March 30, 2022 13:19
@SandyXSD SandyXSD requested a review from davies March 31, 2022 01:50
@davies davies merged commit fe910ad into main Apr 1, 2022
@davies davies deleted the meta-no-empty-name branch April 1, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants