Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta/sql: fix wrong result from scanning SQL database #1854

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

davies
Copy link
Contributor

@davies davies commented Apr 21, 2022

There is a bug in xorm when scanning a binary column, it could return partial or wrong result.

This PR fix that by reset the binary column before scan next row.

@davies davies requested a review from SandyXSD April 21, 2022 04:04
@davies
Copy link
Contributor Author

davies commented Apr 21, 2022

Create a bug for xorm: https://gitea.com/xorm/xorm/issues/2134

pkg/meta/sql.go Outdated Show resolved Hide resolved
pkg/meta/sql.go Show resolved Hide resolved
pkg/meta/sql.go Show resolved Hide resolved
pkg/meta/sql.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #1854 (a05b7e5) into main (179de1f) will increase coverage by 0.14%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #1854      +/-   ##
==========================================
+ Coverage   61.66%   61.81%   +0.14%     
==========================================
  Files         135      135              
  Lines       23019    23042      +23     
==========================================
+ Hits        14195    14243      +48     
+ Misses       7221     7191      -30     
- Partials     1603     1608       +5     
Impacted Files Coverage Δ
pkg/meta/sql.go 66.39% <88.88%> (-0.68%) ⬇️
pkg/meta/sql_lock.go 72.43% <100.00%> (+0.35%) ⬆️
pkg/vfs/writer.go 78.64% <0.00%> (-1.02%) ⬇️
pkg/meta/base.go 71.69% <0.00%> (+0.50%) ⬆️
pkg/chunk/cached_store.go 79.52% <0.00%> (+3.10%) ⬆️
pkg/vfs/reader.go 81.56% <0.00%> (+4.37%) ⬆️
pkg/fuse/context.go 67.56% <0.00%> (+10.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 179de1f...a05b7e5. Read the comment docs.

@davies davies merged commit 637800e into main Apr 21, 2022
@davies davies deleted the fix_sql_scan branch April 21, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants