Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta/sql: add primary key for all tables #1913

Merged
merged 3 commits into from
Apr 26, 2022
Merged

meta/sql: add primary key for all tables #1913

merged 3 commits into from
Apr 26, 2022

Conversation

davies
Copy link
Contributor

@davies davies commented Apr 26, 2022

close #1576

@davies davies requested a review from SandyXSD April 26, 2022 06:39
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2022

Codecov Report

Merging #1913 (e696e69) into main (2d7df98) will decrease coverage by 0.05%.
The diff coverage is 53.33%.

❗ Current head e696e69 differs from pull request most recent head b2ecf55. Consider uploading reports for the commit b2ecf55 to get more accurate results

@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
- Coverage   61.62%   61.57%   -0.06%     
==========================================
  Files         135      135              
  Lines       23433    23434       +1     
==========================================
- Hits        14441    14429      -12     
- Misses       7321     7332      +11     
- Partials     1671     1673       +2     
Impacted Files Coverage Δ
pkg/meta/sql.go 64.73% <53.33%> (-0.10%) ⬇️
pkg/vfs/reader.go 80.29% <0.00%> (-2.56%) ⬇️
pkg/vfs/vfs.go 77.88% <0.00%> (-0.28%) ⬇️
pkg/meta/redis.go 71.64% <0.00%> (-0.05%) ⬇️
pkg/chunk/cached_store.go 76.23% <0.00%> (+0.54%) ⬆️
pkg/vfs/writer.go 79.66% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7df98...b2ecf55. Read the comment docs.

@davies davies merged commit c53b234 into main Apr 26, 2022
@davies davies deleted the pk branch April 26, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert primary keys in all MySQL tables
3 participants