Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: keep valid utf8 in dumped JSON #1973

Merged
merged 5 commits into from
May 9, 2022
Merged

Conversation

zhijian-pro
Copy link
Contributor

Close #1754

@zhijian-pro zhijian-pro requested a review from davies May 7, 2022 08:02
@zhijian-pro zhijian-pro marked this pull request as ready for review May 7, 2022 08:02
@zhijian-pro zhijian-pro marked this pull request as draft May 7, 2022 09:59
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #1973 (b254b54) into main (975011b) will increase coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
+ Coverage   61.59%   61.61%   +0.01%     
==========================================
  Files         135      135              
  Lines       23580    23581       +1     
==========================================
+ Hits        14525    14529       +4     
+ Misses       7375     7373       -2     
+ Partials     1680     1679       -1     
Impacted Files Coverage Δ
pkg/meta/dump.go 76.27% <87.50%> (+0.40%) ⬆️
pkg/meta/sql_lock.go 72.43% <0.00%> (-2.57%) ⬇️
pkg/chunk/cached_store.go 76.05% <0.00%> (-0.19%) ⬇️
pkg/object/azure.go 1.72% <0.00%> (+0.02%) ⬆️
pkg/meta/redis.go 71.88% <0.00%> (+0.04%) ⬆️
pkg/chunk/disk_cache.go 80.33% <0.00%> (+0.48%) ⬆️
pkg/chunk/utils_unix.go 93.33% <0.00%> (+20.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975011b...b254b54. Read the comment docs.

@davies davies changed the title escape skips utf8 encoded bytes meta: keep valid utf8 in dumped JSON May 8, 2022
@davies davies marked this pull request as ready for review May 8, 2022 09:30
@zhijian-pro zhijian-pro merged commit 7cd4656 into main May 9, 2022
@zhijian-pro zhijian-pro deleted the dump_without_escap_utf8_char branch May 9, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't escape for utf-8 filenames/xattrs when dump.
3 participants